From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lkmmg-0003Nk-Vq
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 18:01:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lkmmc-0003NO-8M
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 18:01:46 -0400
Received: from [199.232.76.173] (port=43745 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lkmmc-0003NL-3G
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 18:01:42 -0400
Received: from mail-qy0-f111.google.com ([209.85.221.111]:33272)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Lkmmb-0004SM-KI
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 18:01:41 -0400
Received: by qyk9 with SMTP id 9so1541840qyk.4
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 15:01:40 -0700 (PDT)
Message-ID: <49C41240.8030102@codemonkey.ws>
Date: Fri, 20 Mar 2009 17:01:36 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] r6677 broke access to physical FDD on Win32
References: <49C16D71.7020104@bttr-software.de>
In-Reply-To: <49C16D71.7020104@bttr-software.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Robert Riebisch wrote:
> Hi!
>
> If I run QEMU on Win32 with option "-fda a:", then I'm unable to access
> physical floppies from guest OS. "Physical" also includes virtual drives
> created by <http://chitchat.at.infoseek.co.jp/vmware/vfd.html>.
>
> I'm also unable to boot such floppies ("-boot a"). Error message is:
> "Boot failed: not a bootable floppy disk"
>
> By doing some builds I narrowed the problem down to
> <http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=6677> by
> Anthony Liguori.
>   

I suspect this code:

block-raw-win32.c:raw_getlength():

    case FTYPE_HARDDISK:
        status = DeviceIoControl(s->hfile, IOCTL_DISK_GET_DRIVE_GEOMETRY_EX,
                                 NULL, 0, &dg, sizeof(dg), &count, NULL);
        if (status != 0) {
            l = dg.DiskSize;
        }
        break;

Is not doing the correct thing.

Looking at the code, perhaps you should be saying -fda //./a.  I don't 
know a lot about windows but that sure does look weird to me.

Regards,

Anthony Liguori

> Robert Riebisch
>