qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] r6677 broke access to physical FDD on Win32
Date: Fri, 20 Mar 2009 18:02:24 -0500	[thread overview]
Message-ID: <49C42080.5080802@codemonkey.ws> (raw)
In-Reply-To: <49C4177B.7080405@bttr-software.de>

Robert Riebisch wrote:
> Anthony Liguori wrote:
>
>   
>> block-raw-win32.c:raw_getlength():
>>
>>     case FTYPE_HARDDISK:
>>     
>
> A floppy disk drive is hard disk?
>   

I didn't write the code, but yeah, that confused me too.

>> Looking at the code, perhaps you should be saying -fda //./a.
>>     
>
> "-fda //./a" fails, but "-fda //./a:" works for the stable branch. It
> does NOT work for original qemu-0.10.0.tar.gz.
>
> Now we "just" need to allow the old syntax. :-)
>   

The patch that I wrote fixed a bug where a guest could send IO requests 
to a guest backend that were greater than the size of the device.  The 
size of the device is bdrv_getlength().  In this case, when you specify 
"a:" on Windows, it doesn't correctly detect that it is a physical 
device.  It cannot get the size of the device correctly because of 
this.  This wasn't an issue before because of the aforementioned bug.

Is "a:" a valid filename in Windows?  Is there a way in Windows to 
detect that a given file is actually a physical device?

Regards,

Anthony Liguori

> Robert Riebisch
>   

  reply	other threads:[~2009-03-20 23:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 21:53 [Qemu-devel] r6677 broke access to physical FDD on Win32 Robert Riebisch
2009-03-20 22:01 ` Anthony Liguori
2009-03-20 22:23   ` Robert Riebisch
2009-03-20 23:02     ` Anthony Liguori [this message]
2009-03-20 23:20       ` Luca Tettamanti
2009-03-21  1:56         ` Anthony Liguori
2009-03-22 20:49           ` Robert Riebisch
2009-03-23  2:20             ` Anthony Liguori
2009-03-23 12:31             ` Luca Tettamanti
2009-03-24  8:20               ` Japheth
2009-03-30 19:59                 ` Robert Riebisch
2009-03-21 22:07   ` Luca Tettamanti
2009-04-07  1:46     ` Anthony Liguori
2009-04-07 11:45       ` Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C42080.5080802@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).