From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lknjy-0005BD-Nx
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 19:03:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lknjs-00052f-UW
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 19:03:01 -0400
Received: from [199.232.76.173] (port=50502 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lknjs-000529-N3
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 19:02:56 -0400
Received: from mail-qy0-f111.google.com ([209.85.221.111]:61756)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Lknjs-0006R3-3j
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 19:02:56 -0400
Received: by qyk9 with SMTP id 9so1564515qyk.4
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 16:02:55 -0700 (PDT)
Message-ID: <49C42080.5080802@codemonkey.ws>
Date: Fri, 20 Mar 2009 18:02:24 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] r6677 broke access to physical FDD on Win32
References: <49C16D71.7020104@bttr-software.de>	<49C41240.8030102@codemonkey.ws>
	<49C4177B.7080405@bttr-software.de>
In-Reply-To: <49C4177B.7080405@bttr-software.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Robert Riebisch wrote:
> Anthony Liguori wrote:
>
>   
>> block-raw-win32.c:raw_getlength():
>>
>>     case FTYPE_HARDDISK:
>>     
>
> A floppy disk drive is hard disk?
>   

I didn't write the code, but yeah, that confused me too.

>> Looking at the code, perhaps you should be saying -fda //./a.
>>     
>
> "-fda //./a" fails, but "-fda //./a:" works for the stable branch. It
> does NOT work for original qemu-0.10.0.tar.gz.
>
> Now we "just" need to allow the old syntax. :-)
>   

The patch that I wrote fixed a bug where a guest could send IO requests 
to a guest backend that were greater than the size of the device.  The 
size of the device is bdrv_getlength().  In this case, when you specify 
"a:" on Windows, it doesn't correctly detect that it is a physical 
device.  It cannot get the size of the device correctly because of 
this.  This wasn't an issue before because of the aforementioned bug.

Is "a:" a valid filename in Windows?  Is there a way in Windows to 
detect that a given file is actually a physical device?

Regards,

Anthony Liguori

> Robert Riebisch
>