[Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hello,

starting with r6839, the monitor command 'screendump'
raises a nullpointer memory access which crashs Qemu.

My patch fixes this for trunk and for the stable branch.

Regards

Stefan

PS. There are a lot of unapplied patches (not only from me)
which really should be applied to trunk. Much time and efforts
are wasted for maintaining local patch trees, some fixes
are sent 3 times by different people. How can we improve
this insatisfying situation?






[-- Attachment #2: screendump.patch --]
[-- Type: text/x-diff, Size: 673 bytes --]

Fix crash when calling screendump from monitor.

This was a regression introduced with r6839:
DisplayAllocator interface (Stefano Stabellini)

Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Index: trunk/hw/vga.c
===================================================================
--- trunk.orig/hw/vga.c	2009-03-24 19:35:00.000000000 +0100
+++ trunk/hw/vga.c	2009-03-24 19:37:56.000000000 +0100
@@ -2637,6 +2637,7 @@
     dcl.dpy_resize = vga_save_dpy_resize;
     dcl.dpy_refresh = vga_save_dpy_refresh;
     register_displaychangelistener(ds, &dcl);
+    ds->allocator = &default_allocator;
     ds->surface = qemu_create_displaysurface(ds, w, h);
 
     s->ds = ds;

Re: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Anthony Liguori]

Stefan Weil wrote:
> Hello,
>
> starting with r6839, the monitor command 'screendump'
> raises a nullpointer memory access which crashs Qemu.
>
> My patch fixes this for trunk and for the stable branch.
>   

r6839 is not in stable so the patch isn't needed for stable.

> Regards
>
> Stefan
>
> PS. There are a lot of unapplied patches (not only from me)
> which really should be applied to trunk. Much time and efforts
> are wasted for maintaining local patch trees, some fixes
> are sent 3 times by different people. How can we improve
> this insatisfying situation?
>   

What are the unapplied patches?  I have about 30 patches in my queue.  
Even the oldest (which had comments so I'll probably drop from my queue) 
are less than 2 weeks old.  I don't have any unapplied patches from you 
in my queue.

There are certain subsystems that do not have an active maintainer right 
now.  Really there is no solution for this without something stepping up 
to active maintain those subsystems.  That basically requires someone 
devoting some time to maintaining a queue for that subsystem.

Regards,

Anthony Liguori

>
>
>
>   

Re: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Ryan Harper]

* Stefan Weil <weil@mail.berlios.de> [2009-03-24 17:16]:
> Hello,
> 
> starting with r6839, the monitor command 'screendump'
> raises a nullpointer memory access which crashs Qemu.
> 
> My patch fixes this for trunk and for the stable branch.
> 
> Regards
> 
> Stefan
> 
> PS. There are a lot of unapplied patches (not only from me)
> which really should be applied to trunk. Much time and efforts
> are wasted for maintaining local patch trees, some fixes
> are sent 3 times by different people. How can we improve
> this insatisfying situation?
> 
> 
> 
> 
> 

> Fix crash when calling screendump from monitor.
> 
> This was a regression introduced with r6839:
> DisplayAllocator interface (Stefano Stabellini)
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Acked-by: Ryan Harper <ryanh@us.ibm.com>

> 
> Index: trunk/hw/vga.c
> ===================================================================
> --- trunk.orig/hw/vga.c	2009-03-24 19:35:00.000000000 +0100
> +++ trunk/hw/vga.c	2009-03-24 19:37:56.000000000 +0100
> @@ -2637,6 +2637,7 @@
>      dcl.dpy_resize = vga_save_dpy_resize;
>      dcl.dpy_refresh = vga_save_dpy_refresh;
>      register_displaychangelistener(ds, &dcl);
> +    ds->allocator = &default_allocator;
>      ds->surface = qemu_create_displaysurface(ds, w, h);
> 
>      s->ds = ds;


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com

Re: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Stefano Stabellini]

Stefan Weil wrote:

> Hello,
> 
> starting with r6839, the monitor command 'screendump'
> raises a nullpointer memory access which crashs Qemu.
> 
> My patch fixes this for trunk and for the stable branch.
> 

Acked-by: stefano.stabellini@eu.citrix.com

Re: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Anthony Liguori]

Stefan Weil wrote:
> Hello,
>
> starting with r6839, the monitor command 'screendump'
> raises a nullpointer memory access which crashs Qemu.
>
> My patch fixes this for trunk and for the stable branch.
>   

Applied to trunk.  Stable doesn't have the DisplayAllocator interface so 
this bug isn't present there.

Regards,

Anthony Liguori

> Regards
>
> Stefan
>
>
>
>