From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LmEOt-00048b-FQ
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 17:43:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LmEOo-00046K-QT
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 17:43:11 -0400
Received: from [199.232.76.173] (port=33570 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LmEOo-00046C-Gf
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 17:43:06 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:58028)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1LmEOn-0003VJ-T4
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 17:43:06 -0400
Message-ID: <49C953E2.8090702@mail.berlios.de>
Date: Tue, 24 Mar 2009 22:42:58 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)
Content-Type: multipart/mixed; boundary="------------040203010405010303060503"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@us.ibm.com>

This is a multi-part message in MIME format.
--------------040203010405010303060503
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

Hello,

starting with r6839, the monitor command 'screendump'
raises a nullpointer memory access which crashs Qemu.

My patch fixes this for trunk and for the stable branch.

Regards

Stefan

PS. There are a lot of unapplied patches (not only from me)
which really should be applied to trunk. Much time and efforts
are wasted for maintaining local patch trees, some fixes
are sent 3 times by different people. How can we improve
this insatisfying situation?






--------------040203010405010303060503
Content-Type: text/x-diff;
 name="screendump.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="screendump.patch"

Fix crash when calling screendump from monitor.

This was a regression introduced with r6839:
DisplayAllocator interface (Stefano Stabellini)

Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Index: trunk/hw/vga.c
===================================================================
--- trunk.orig/hw/vga.c	2009-03-24 19:35:00.000000000 +0100
+++ trunk/hw/vga.c	2009-03-24 19:37:56.000000000 +0100
@@ -2637,6 +2637,7 @@
     dcl.dpy_resize = vga_save_dpy_resize;
     dcl.dpy_refresh = vga_save_dpy_refresh;
     register_displaychangelistener(ds, &dcl);
+    ds->allocator = &default_allocator;
     ds->surface = qemu_create_displaysurface(ds, w, h);
 
     s->ds = ds;

--------------040203010405010303060503--