From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LmZE3-000473-F2
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:57:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LmZDy-00044O-OI
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:57:23 -0400
Received: from [199.232.76.173] (port=53547 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LmZDy-00044I-Fr
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:57:18 -0400
Received: from e1.ny.us.ibm.com ([32.97.182.141]:57300)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LmZDy-0001Du-3P
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:57:18 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2PJsL1Q001372
	for <qemu-devel@nongnu.org>; Wed, 25 Mar 2009 15:54:21 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n2PJuxkZ171010
	for <qemu-devel@nongnu.org>; Wed, 25 Mar 2009 15:56:59 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n2PJuwKG016033
	for <qemu-devel@nongnu.org>; Wed, 25 Mar 2009 15:56:59 -0400
Message-ID: <49CA8C88.7040806@us.ibm.com>
Date: Wed, 25 Mar 2009 14:56:56 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile
References: <1238006714-27209-1-git-send-email-glommer@redhat.com>
	<20090325194902.GA19843@kos.to>
In-Reply-To: <20090325194902.GA19843@kos.to>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: markmc@redhat.com, qemu-devel@nongnu.org

Riku Voipio wrote:
> On Wed, Mar 25, 2009 at 03:45:14PM -0300, Glauber Costa wrote:
>   
>> install -s is pretty and cute, but makes the binary get into the build
>> directory without any debug information. This is bad, and makes glommer
>> sad. Also, tools that attempt to extract that data, like fedora debuginfo
>> extractor, will fail.
>>     
>
> Fully ACK, but you'll want to fix that in Makefile.target too.
>   

Does anyone object to this?  I know Debian also carries a similar patch.

Regards,

Anthony Liguori

>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>> ---
>>  Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 82fec80..859614b 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -251,7 +251,7 @@ endif
>>  install: all $(if $(BUILD_DOCS),install-doc)
>>  	mkdir -p "$(DESTDIR)$(bindir)"
>>  ifneq ($(TOOLS),)
>> -	$(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
>> +	$(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
>>  endif
>>  ifneq ($(BLOBS),)
>>  	mkdir -p "$(DESTDIR)$(datadir)"
>> -- 
>> 1.6.0.6
>>
>>
>>     
>
>