From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lmuew-0005eS-HJ
	for qemu-devel@nongnu.org; Thu, 26 Mar 2009 14:50:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lmueq-0005bT-En
	for qemu-devel@nongnu.org; Thu, 26 Mar 2009 14:50:32 -0400
Received: from [199.232.76.173] (port=45273 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lmueq-0005bL-3d
	for qemu-devel@nongnu.org; Thu, 26 Mar 2009 14:50:28 -0400
Received: from mx2.redhat.com ([66.187.237.31]:36909)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Lmuep-00047J-Lr
	for qemu-devel@nongnu.org; Thu, 26 Mar 2009 14:50:27 -0400
Message-ID: <49CBCE91.1030307@redhat.com>
Date: Thu, 26 Mar 2009 20:50:57 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile
References: <1238006714-27209-1-git-send-email-glommer@redhat.com>	<20090325194902.GA19843@kos.to>
	<49CA8C88.7040806@us.ibm.com>
In-Reply-To: <49CA8C88.7040806@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: markmc@redhat.com, Riku Voipio <riku.voipio@iki.fi>

Anthony Liguori wrote:
> Riku Voipio wrote:
>> On Wed, Mar 25, 2009 at 03:45:14PM -0300, Glauber Costa wrote:
>>  
>>> install -s is pretty and cute, but makes the binary get into the build
>>> directory without any debug information. This is bad, and makes glommer
>>> sad. Also, tools that attempt to extract that data, like fedora 
>>> debuginfo
>>> extractor, will fail.
>>>     
>>
>> Fully ACK, but you'll want to fix that in Makefile.target too.
>>   
>
> Does anyone object to this?  I know Debian also carries a similar patch.

If people complain, we can add a ./configure flag for it.  But I doubt 
anyone will notice; the floppy days are gone.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.