qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] honor IDE_DMA_BUF_SECTORS
Date: Fri, 27 Mar 2009 13:58:20 +0300	[thread overview]
Message-ID: <49CCB14C.1080607@redhat.com> (raw)
In-Reply-To: <20090327103628.GF5408@const.bordeaux.inria.fr>

Samuel Thibault wrote:
>> But posix read/write does not fit how DMA works.  A request should
>> either complete fully, or fail, leaving the destination (disk or
>> memory) in an undefined state.
>>     
>
> Sure.  Again, please read what _I_ wrote: I'm not proposing to expose
> that into DMA, just make it genericly handled in the block layer.

Okay.  I oppose making short reads part of the API.  Callers should 
expect the return code to be either zero, or a failure indication.

If you want generic block layer support, it could come in the form of 
helpers, that is a block format driver could call 
bdrv_continue_partial_request(lots, of, parameters) to have the helper 
advance the iovec and reissue the partially completed request.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

  reply	other threads:[~2009-03-27 10:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 13:45 [Qemu-devel] [PATCH] honor IDE_DMA_BUF_SECTORS Stefano Stabellini
2009-03-25 15:22 ` Avi Kivity
2009-03-25 16:19   ` Stefano Stabellini
2009-03-25 16:45     ` Avi Kivity
2009-03-25 16:50       ` Stefano Stabellini
2009-03-25 17:47         ` Stefano Stabellini
2009-03-26 10:23           ` Avi Kivity
2009-03-26 10:31             ` Stefano Stabellini
2009-03-26 10:57               ` Avi Kivity
2009-03-26 11:45                 ` Stefano Stabellini
2009-03-26 12:10                   ` Avi Kivity
2009-03-26 12:28                     ` Stefano Stabellini
2009-03-26 12:47                     ` Samuel Thibault
2009-03-26 12:58                       ` Avi Kivity
2009-03-26 15:30                         ` Samuel Thibault
2009-03-26 18:32                           ` Avi Kivity
2009-03-26 18:48                             ` Samuel Thibault
2009-03-26 19:40                               ` Avi Kivity
2009-03-26 23:18                                 ` Samuel Thibault
2009-03-27  9:52                                   ` Avi Kivity
2009-03-27 10:32                                     ` Samuel Thibault
2009-03-27 10:53                                       ` Avi Kivity
2009-03-27 13:45                                         ` Samuel Thibault
2009-03-26 22:42                   ` Christoph Hellwig
2009-03-26 23:22                     ` Samuel Thibault
2009-03-27 10:02                       ` Avi Kivity
2009-03-27 10:36                         ` Samuel Thibault
2009-03-27 10:58                           ` Avi Kivity [this message]
2009-03-25 16:46     ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CCB14C.1080607@redhat.com \
    --to=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).