qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH] get roms more room.
Date: Sat, 28 Mar 2009 09:51:16 +0100	[thread overview]
Message-ID: <49CDE504.5020807@gmx.net> (raw)
In-Reply-To: <1238214323-3226-1-git-send-email-glommer@redhat.com>

On 28.03.2009 05:25, Glauber Costa wrote:
> This patch increases by 50 % the size available for option roms.
> The main motivator is that some roms grew bigger than the 64k we
> currently allocate for them (Hey, it's 2009!)
>
> One example is the gpxe project, that produces some roms with 69k,
> 70k, etc. The space proposed by this patch actually makes it as
> big as 84k. Probably still a fit for some time.
>
> But there is no free lunch. This space must come from somewhere,
> and we take it from vga rom space. Currently, our vga roms are
> around 35k in size. With this patch, option rom space will begin
> just after vga ends, aligned to the next 2k boundary.
>
> Technicaly, we could do the same with the uper space (the bios itself),
> but since bochs bios is already 128 k in size, I don't see an
> urgent need to do it.
>
> [ fix case for vgabioses smaller than 30k, by Carl-Daniel Hailfinger ]
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
>   

Thanks for your patience with my comments!

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/

  reply	other threads:[~2009-03-28  8:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-28  4:25 [Qemu-devel] [PATCH] get roms more room Glauber Costa
2009-03-28  8:51 ` Carl-Daniel Hailfinger [this message]
2009-03-28 17:30 ` Anthony Liguori
2009-03-28 22:25   ` Glauber Costa
  -- strict thread matches above, loose matches on Subject: below --
2009-03-27 23:48 Glauber Costa
2009-03-28  1:58 ` Carl-Daniel Hailfinger
2009-03-28  4:19   ` Glauber Costa
2009-03-27 17:37 Glauber Costa
2009-03-27 20:29 ` Carl-Daniel Hailfinger
2009-03-27 20:45   ` Glauber Costa
2009-03-27 23:12     ` Carl-Daniel Hailfinger
2009-03-27 23:43       ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CDE504.5020807@gmx.net \
    --to=c-d.hailfinger.devel.2006@gmx.net \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).