From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnUGD-00034y-0f for qemu-devel@nongnu.org; Sat, 28 Mar 2009 04:51:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnUG8-0002zJ-9v for qemu-devel@nongnu.org; Sat, 28 Mar 2009 04:51:24 -0400 Received: from [199.232.76.173] (port=53878 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnUG8-0002z8-2h for qemu-devel@nongnu.org; Sat, 28 Mar 2009 04:51:20 -0400 Received: from mail.gmx.net ([213.165.64.20]:46037) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LnUG7-00016m-ES for qemu-devel@nongnu.org; Sat, 28 Mar 2009 04:51:19 -0400 Message-ID: <49CDE504.5020807@gmx.net> Date: Sat, 28 Mar 2009 09:51:16 +0100 From: Carl-Daniel Hailfinger MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] get roms more room. References: <1238214323-3226-1-git-send-email-glommer@redhat.com> In-Reply-To: <1238214323-3226-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com On 28.03.2009 05:25, Glauber Costa wrote: > This patch increases by 50 % the size available for option roms. > The main motivator is that some roms grew bigger than the 64k we > currently allocate for them (Hey, it's 2009!) > > One example is the gpxe project, that produces some roms with 69k, > 70k, etc. The space proposed by this patch actually makes it as > big as 84k. Probably still a fit for some time. > > But there is no free lunch. This space must come from somewhere, > and we take it from vga rom space. Currently, our vga roms are > around 35k in size. With this patch, option rom space will begin > just after vga ends, aligned to the next 2k boundary. > > Technicaly, we could do the same with the uper space (the bios itself), > but since bochs bios is already 128 k in size, I don't see an > urgent need to do it. > > [ fix case for vgabioses smaller than 30k, by Carl-Daniel Hailfinger ] > > Signed-off-by: Glauber Costa > Thanks for your patience with my comments! Acked-by: Carl-Daniel Hailfinger Regards, Carl-Daniel -- http://www.hailfinger.org/