From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LncLj-0003Hq-6D
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:29:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LncLe-0003Fv-Ky
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:29:38 -0400
Received: from [199.232.76.173] (port=57026 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LncLe-0003Fq-HO
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:29:34 -0400
Received: from e5.ny.us.ibm.com ([32.97.182.145]:35764)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LncLe-0006EH-2t
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:29:34 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e5.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2SHPhf5006809
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:25:43 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n2SHTWRA184604
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:29:32 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n2SHTVDN023710
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:29:31 -0400
Received: from squirrel.codemonkey.ws (sig-9-65-67-103.mts.ibm.com
	[9.65.67.103])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n2SHTUWb023693
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:29:31 -0400
Message-ID: <49CE5E7A.90108@us.ibm.com>
Date: Sat, 28 Mar 2009 12:29:30 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] gdbstub: Drop redundant memset
	after	qemu_mallocz
References: <49BFDBA7.90508@siemens.com>
In-Reply-To: <49BFDBA7.90508@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>
>  gdbstub.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 1191dc2..935d864 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2274,8 +2274,6 @@ static void gdb_accept(void)
>      setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, (char *)&val, sizeof(val));
>  
>      s = qemu_mallocz(sizeof(GDBState));
> -
> -    memset (s, 0, sizeof (GDBState));
>      s->c_cpu = first_cpu;
>      s->g_cpu = first_cpu;
>      s->fd = fd;
>
>
>
>