From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LncN8-0003g0-HQ
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LncN3-0003dy-BL
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:05 -0400
Received: from [199.232.76.173] (port=48619 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LncN2-0003dq-SS
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:01 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:45344)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LncN1-0006Kb-Ng
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:00 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e9.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2SHLUlo005294
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:21:30 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n2SHUqJk199092
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:30:52 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n2SHUqN2025094
	for <qemu-devel@nongnu.org>; Sat, 28 Mar 2009 13:30:52 -0400
Message-ID: <49CE5ECB.1040905@us.ibm.com>
Date: Sat, 28 Mar 2009 12:30:51 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] new scsi-generic abstraction, use SG_IO
References: <20090318133633.GA24254@lst.de>
In-Reply-To: <20090318133633.GA24254@lst.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>

Christoph Hellwig wrote:
> Okay, I started looking into how to handle scsi-generic I/O in the
> new world order.
>
> I think the best is to use the SG_IO ioctl instead of the read/write
> interface as that allows us to support scsi passthrough on disk/cdrom
> devices, too.  See Hannes patch on the kvm list from August for an
> example.
>
> Now that we always do ioctls we don't need another abstraction than
> bdrv_ioctl for the synchronous requests for now, and for asynchronous
> requests I've added a aio_ioctl abstraction keeping it simple.
>
> Long-term we might want to move the ops to a higher-level abstraction
> and let the low-level code fill out the request header, but I'm lazy
> enough to leave that to the people trying to support scsi-passthrough
> on a non-Linux OS.
>
> Tested lightly by issuing various sg_ commands from sg3-utils in a guest
> to a host CDROM device.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>   

Applied.  Thanks.

Regards,

Anthony Liguori