From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LncNv-0003zX-Vz for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LncNr-0003yp-F9 for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:55 -0400 Received: from [199.232.76.173] (port=48644 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LncNr-0003yj-1x for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:51 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:44105) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LncNq-0006Rn-QY for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:31:50 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2SHSpXY008981 for ; Sat, 28 Mar 2009 13:28:51 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2SHVo56185374 for ; Sat, 28 Mar 2009 13:31:50 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2SHVonK008240 for ; Sat, 28 Mar 2009 13:31:50 -0400 Received: from squirrel.codemonkey.ws (sig-9-65-67-103.mts.ibm.com [9.65.67.103]) by d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2SHVnL1008231 for ; Sat, 28 Mar 2009 13:31:49 -0400 Message-ID: <49CE5F04.1000708@us.ibm.com> Date: Sat, 28 Mar 2009 12:31:48 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] [STABLE] Clean some PCI defines References: <49C62504.8070208@mail.berlios.de> In-Reply-To: <49C62504.8070208@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefan Weil wrote: > Hello, > > this patch adds some more defines from linux/pci_regs.h to > hw/pci.h. There is now no longer a need to define them in > eepro100.c, so they were removed there. > > Some defines from linux/pci_regs.h had similar, but not > the same defines in hw/pci.h (PCI_REVISION_ID / PCI_REVISION, > PCI_SUBSYSTEM_VENDOR_ID / PCI_SUBVENDOR_ID, > PCI_SUBSYSTEM_ID / PCI_SUBDEVICE_ID). > > I suggest to use the "standard" from linux/pci_regs.h and > replace the "old" Qemu ones. To facilitate the migration, > my patch does not remove the old defines but marks them > as obsolete. After a migration to the "standard" defines, > pci.h could use linux/pci_regs.h which is far more complete. > > The patch is needed for an updated maintainer version of > hw/eepro100.c which I'd like to see in Qemu stable. > Applied to trunk. Since this isn't a bug fix, I don't think it's appropriate for stable. If you have another bug fix in your queue that depends on this patch, I'd rather that a simpler change be used. Regards, Anthony Liguori > Regards > > Stefan Weil > > > >