From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnchP-0004aW-FP for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:52:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnchK-0004X9-LG for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:52:03 -0400 Received: from [199.232.76.173] (port=39328 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnchK-0004X2-8K for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:51:58 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:54996) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LnchJ-0001Kv-Qg for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:51:58 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2SHpT2g002854 for ; Sat, 28 Mar 2009 11:51:29 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2SHpueP204736 for ; Sat, 28 Mar 2009 11:51:56 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2SHpuBJ005956 for ; Sat, 28 Mar 2009 11:51:56 -0600 Received: from squirrel.codemonkey.ws (sig-9-65-67-103.mts.ibm.com [9.65.67.103]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2SHpt84005932 for ; Sat, 28 Mar 2009 11:51:56 -0600 Message-ID: <49CE63BA.3060303@us.ibm.com> Date: Sat, 28 Mar 2009 12:51:54 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] ROM write access for debugging References: <49BFDB53.9020004@siemens.com> In-Reply-To: <49BFDB53.9020004@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > Enhance cpu_memory_rw_debug so that it can write even to ROM regions. > This allows to modify ROM via gdb (I see no point in denying this to the > user), and it will enable us to drop kvm_patch_opcode_byte(). > > Credits go to Avi for suggesting this. > > Signed-off-by: Jan Kiszka > Applied both in series. Thanks. Regards, Anthony Liguori > --- > > exec.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/exec.c b/exec.c > index 86ab7de..5e94a8f 100644 > --- a/exec.c > +++ b/exec.c > @@ -3448,7 +3448,7 @@ void stq_phys(target_phys_addr_t addr, uint64_t val) > > #endif > > -/* virtual memory access for debug */ > +/* virtual memory access for debug (includes writing to ROM) */ > int cpu_memory_rw_debug(CPUState *env, target_ulong addr, > uint8_t *buf, int len, int is_write) > { > @@ -3465,8 +3465,13 @@ int cpu_memory_rw_debug(CPUState *env, target_ulong addr, > l = (page + TARGET_PAGE_SIZE) - addr; > if (l > len) > l = len; > - cpu_physical_memory_rw(phys_addr + (addr & ~TARGET_PAGE_MASK), > - buf, l, is_write); > + phys_addr += (addr & ~TARGET_PAGE_MASK); > +#if !defined(CONFIG_USER_ONLY) > + if (is_write) > + cpu_physical_memory_write_rom(phys_addr, buf, l); > + else > +#endif > + cpu_physical_memory_rw(phys_addr, buf, l, is_write); > len -= l; > buf += l; > addr += l; > > > >