From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lnckk-0007nY-Vk for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:55:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lnckf-0007fu-SJ for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:55:30 -0400 Received: from [199.232.76.173] (port=43003 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lnckf-0007fd-Mb for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:55:25 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:52896) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lnckf-0001i8-A0 for qemu-devel@nongnu.org; Sat, 28 Mar 2009 13:55:25 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e8.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2SHl5Po013789 for ; Sat, 28 Mar 2009 13:47:05 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2SHtOSt172402 for ; Sat, 28 Mar 2009 13:55:24 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2SHrqXX015634 for ; Sat, 28 Mar 2009 13:53:52 -0400 Received: from squirrel.codemonkey.ws (sig-9-65-67-103.mts.ibm.com [9.65.67.103]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2SHrp8s015624 for ; Sat, 28 Mar 2009 13:53:52 -0400 Message-ID: <49CE648A.1040407@us.ibm.com> Date: Sat, 28 Mar 2009 12:55:22 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] keep and use backing file format (v7) References: <1238018112-7569-1-git-send-email-uril@redhat.com> In-Reply-To: <1238018112-7569-1-git-send-email-uril@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Uri Lublin wrote: > In this patchset there are two main features: > 1. Introduce Qcow2 extensions. > 2. Keep backing file format such that no probing is needed. > > 1. Qcow2 extensions are build of magic (id) len (in bytes) and data. > They reside between the end of the header and the backing filename (if exists). > Unknown extensions are ignored (assumed to be added by a newer version) > Based on a work done by Shahar Frank. > > 2. By keeping the backing file format we: > a. Provide a way to know the backing file format without probing > it (setting the format at creation time). > b. Enable using qcow2 format over host block devices. > (only if the user specifically asks for it, by providing the format > at creation time). > > I've added bdrv_create2 and drv->bdrv_create2 (implemented only > by block-qcow2 currently) to pass the backing-format to create. > > Also fixes a security flaw found by Daniel P. Berrange on [1] > which summarizes: "Autoprobing: just say no." > > [1] http://lists.gnu.org/archive/html/qemu-devel/2008-12/msg01083.html > > Changes from v6: > Rebased. > Postponed highest-allocated-block patches. > Applied all. Thanks. Regards, Anthony Liguori > > >