[Qemu-devel] [PATCH] fix format string warnings in block-qcow2.c

[Qemu-devel] [PATCH] fix format string warnings in block-qcow2.c

[Christoph Hellwig]

Recent patches added two compiler warnings about the format string
usage in qcow_read_extensions.  One is printing a uint64_t using
%lu which is incorrect on many platforms as it can be a unsigned
long long, the second one is printing the result of sizeof as
%lu, but it is a size_t so it needs to be printed using %zu.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: qemu/block-qcow2.c
===================================================================
--- qemu.orig/block-qcow2.c	2009-03-28 19:43:58.494882416 +0100
+++ qemu/block-qcow2.c	2009-03-28 19:48:02.766981793 +0100
@@ -223,8 +223,8 @@ static int qcow_read_extensions(BlockDri
 #endif
 
         if (bdrv_pread(s->hd, offset, &ext, sizeof(ext)) != sizeof(ext)) {
-            fprintf(stderr, "qcow_handle_extension: ERROR: pread fail from offset %lu\n",
-                    offset);
+            fprintf(stderr, "qcow_handle_extension: ERROR: pread fail from offset %llu\n",
+                    (unsigned long long)offset);
             return 1;
         }
         be32_to_cpus(&ext.magic);
@@ -240,7 +240,7 @@ static int qcow_read_extensions(BlockDri
         case QCOW_EXT_MAGIC_BACKING_FORMAT:
             if (ext.len >= sizeof(bs->backing_format)) {
                 fprintf(stderr, "ERROR: ext_backing_format: len=%u too large"
-                        " (>=%lu)\n",
+                        " (>=%zu)\n",
                         ext.len, sizeof(bs->backing_format));
                 return 2;
             }

Re: [Qemu-devel] [PATCH] fix format string warnings in block-qcow2.c

[Anthony Liguori]

Christoph Hellwig wrote:
> Recent patches added two compiler warnings about the format string
> usage in qcow_read_extensions.  One is printing a uint64_t using
> %lu which is incorrect on many platforms as it can be a unsigned
> long long, the second one is printing the result of sizeof as
> %lu, but it is a size_t so it needs to be printed using %zu.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> Index: qemu/block-qcow2.c
> ===================================================================
> --- qemu.orig/block-qcow2.c	2009-03-28 19:43:58.494882416 +0100
> +++ qemu/block-qcow2.c	2009-03-28 19:48:02.766981793 +0100
> @@ -223,8 +223,8 @@ static int qcow_read_extensions(BlockDri
>  #endif
>  
>          if (bdrv_pread(s->hd, offset, &ext, sizeof(ext)) != sizeof(ext)) {
> -            fprintf(stderr, "qcow_handle_extension: ERROR: pread fail from offset %lu\n",
> -                    offset);
> +            fprintf(stderr, "qcow_handle_extension: ERROR: pread fail from offset %llu\n",
> +                    (unsigned long long)offset);
>              return 1;
>          }
>          be32_to_cpus(&ext.magic);
> @@ -240,7 +240,7 @@ static int qcow_read_extensions(BlockDri
>          case QCOW_EXT_MAGIC_BACKING_FORMAT:
>              if (ext.len >= sizeof(bs->backing_format)) {
>                  fprintf(stderr, "ERROR: ext_backing_format: len=%u too large"
> -                        " (>=%lu)\n",
> +                        " (>=%zu)\n",
>                          ext.len, sizeof(bs->backing_format));
>                  return 2;
>              }
>
>
>
>