From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lo0Sp-0008Kc-ID for qemu-devel@nongnu.org; Sun, 29 Mar 2009 15:14:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lo0Sk-0008Jw-Ow for qemu-devel@nongnu.org; Sun, 29 Mar 2009 15:14:35 -0400 Received: from [199.232.76.173] (port=57292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lo0Sk-0008Jt-Jl for qemu-devel@nongnu.org; Sun, 29 Mar 2009 15:14:30 -0400 Received: from mail-gx0-f176.google.com ([209.85.217.176]:45009) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lo0Sk-0001EY-9M for qemu-devel@nongnu.org; Sun, 29 Mar 2009 15:14:30 -0400 Received: by gxk24 with SMTP id 24so3651234gxk.10 for ; Sun, 29 Mar 2009 12:14:29 -0700 (PDT) Message-ID: <49CFC892.8050006@codemonkey.ws> Date: Sun, 29 Mar 2009 14:14:26 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4 References: <49CF9EBF.7050601@redhat.com> In-Reply-To: <49CF9EBF.7050601@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Avi Kivity wrote: > Blue Swirl wrote: >> Log Message: >> ----------- >> misc scsi disk/cdrom fixes/improvements 1/4 >> >> Use correct sector size for cdrom Read TOC command >> > > Meta-comment: in git of the log message, the first line is usually a > summary of the commit; so if we're planning to switch to git, subjects > like 'fixed content ?/n' are not helpful. Regardless of git or not, it's useful when sending a patch series to make the subject descriptive as opposed to a boiler plate 'series N/M'. A CodingStyle/SubmittingPatches for QEMU would be rather useful. Regards, Anthony Liguori