From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LoNZ1-0004Fs-MC for qemu-devel@nongnu.org; Mon, 30 Mar 2009 15:54:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LoNYx-0004Au-WF for qemu-devel@nongnu.org; Mon, 30 Mar 2009 15:54:31 -0400 Received: from [199.232.76.173] (port=44492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LoNYx-0004AW-Ag for qemu-devel@nongnu.org; Mon, 30 Mar 2009 15:54:27 -0400 Received: from mx2.redhat.com ([66.187.237.31]:50338) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LoNYw-0008Hv-Ph for qemu-devel@nongnu.org; Mon, 30 Mar 2009 15:54:27 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2UJsPnJ012835 for ; Mon, 30 Mar 2009 15:54:26 -0400 Message-ID: <49D12392.6040107@redhat.com> Date: Mon, 30 Mar 2009 22:54:58 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style References: <1238361823-24939-1-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: >> +4. Block structure >> + >> +Every indented statement is braced; even if the block contains just one >> +statement. >> > > I'd remove this, braces are not used consistently for one statement blocks. > > While that's true, I'd like to keep this. I found (after initially being annoyed by this; I dislike punctuation) that it's nice not to need to rebrace after adding or removing lines. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.