From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lof67-0005Hp-Kn
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:37:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lof62-0005Gm-1F
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:37:50 -0400
Received: from [199.232.76.173] (port=48891 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lof61-0005Gc-P1
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:37:45 -0400
Received: from qw-out-1920.google.com ([74.125.92.148]:48981)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Lof61-0006aY-Dm
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:37:45 -0400
Received: by qw-out-1920.google.com with SMTP id 5so1648804qwf.4
	for <qemu-devel@nongnu.org>; Tue, 31 Mar 2009 07:37:45 -0700 (PDT)
Message-ID: <49D22AA7.1000701@codemonkey.ws>
Date: Tue, 31 Mar 2009 09:37:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1238506137-9140-1-git-send-email-andre.przywara@amd.com>
In-Reply-To: <1238506137-9140-1-git-send-email-andre.przywara@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/4] add NUMA emulation
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andre Przywara <andre.przywara@amd.com>
Cc: qemu-devel@nongnu.org

Andre Przywara wrote:
> Hi,
>
> the following patches add NUMA emulation to QEMU guests.
> Although the ultimate goal is KVM with host side support, these
> patches are pure QEMU with no host side binding.
> This is a reworked version from end of last year, I adapted the command line
> syntax to Anthony's wishes:
> -numa node[,mem=<size>[MG]][,cpus=<from>[-<to>]][,nodeid=<nr>]
> If we agree to this scheme (which drops mem=from-to and requires at least
> one -numa node for each NUMA node), I will provide more detailed documentation.
> Patch 1/4 adds the -numa command line parameter and sets a QEMU global
> array with the parsed values. If no specific values for memory and CPUs are
> given, all resources will be split equally across all nodes.
> Patch 2/4 adds an "info numa" command to the monitor to output the current
> topology. Since NUMA is advertised via static ACPI tables, no changes are
> possible during runtime.
> Patch 3/4 uses the QEMU firmware configuration interfacce to send the NUMA
> topology to the BIOS, which has to setup the tables. Only one channel is used.
> Patch 4/4 finally adds the BIOS support, which create the appropriate
> SRAT table reflecting the given topology.
>
> Looking forward to any comments.
>   

Other than a few minor comments, it's look really good.

Regards,

Anthony Liguori