From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lpj1t-0000XJ-OV
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 09:01:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lpj1q-0000UM-65
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 09:01:53 -0400
Received: from [199.232.76.173] (port=34930 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lpj1n-0000U6-Rr
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 09:01:49 -0400
Received: from an-out-0708.google.com ([209.85.132.242]:16768)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Lpj1n-000122-AR
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 09:01:47 -0400
Received: by an-out-0708.google.com with SMTP id c5so699469anc.37
	for <qemu-devel@nongnu.org>; Fri, 03 Apr 2009 06:01:46 -0700 (PDT)
Message-ID: <49D608B0.2090909@codemonkey.ws>
Date: Fri, 03 Apr 2009 08:01:36 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC] Introduce module API to QEMU
References: <1238724755-15929-1-git-send-email-aliguori@us.ibm.com>
	<1238742496.2510.22.camel@blaa>
In-Reply-To: <1238742496.2510.22.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>

Mark McLoughlin wrote:
> Hey,
>
> Generally looks good to me.
>
> On Thu, 2009-04-02 at 21:12 -0500, Anthony Liguori wrote:
>   
>> diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
>> index 413c569..49ae69b 100644
>> --- a/hw/mcf_fec.c
>> +++ b/hw/mcf_fec.c
>> @@ -446,8 +446,6 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t base, qemu_irq *irq)
>>      mcf_fec_state *s;
>>      int iomemtype;
>>  
>> -    qemu_check_nic_model(nd, "mcf_fec");
>>     
>
> It's obscure, but this line does three things:
>
>   1) Makes 'qemu-system-m68k -net nic,model=?' list the available model
>
>   2) Makes 'qemu-system-m68k -net nic,model=e1000' fail
>
>   3) Makes 'qemu-system-m68k -net nic' have sane 'info network' output 
>      - i.e. the model is listed as mcf_fec
>
> That goes for the other non-PCI NICs too.
>   

Okay, I was afraid of this.  I'll make the non-PCI nics behave similar 
to the PCI ones.

Regards,

Anthony Liguori

> Cheers,
> Mark.
>
>
>
>