From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LpnK1-0001Cp-Sm
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 13:36:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LpnJw-0001CY-7Y
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 13:36:52 -0400
Received: from [199.232.76.173] (port=43305 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LpnJv-0001CV-V9
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 13:36:47 -0400
Received: from wa-out-1112.google.com ([209.85.146.182]:13594)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LpnJv-0007DU-D0
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 13:36:47 -0400
Received: by wa-out-1112.google.com with SMTP id m33so715138wag.18
	for <qemu-devel@nongnu.org>; Fri, 03 Apr 2009 10:36:46 -0700 (PDT)
Message-ID: <49D6492A.6060606@codemonkey.ws>
Date: Fri, 03 Apr 2009 12:36:42 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC] Introduce module API to QEMU
References: <1238724755-15929-1-git-send-email-aliguori@us.ibm.com>
	<1238742496.2510.22.camel@blaa>
In-Reply-To: <1238742496.2510.22.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>

Mark McLoughlin wrote:
> Hey,
>
> Generally looks good to me.
>
> On Thu, 2009-04-02 at 21:12 -0500, Anthony Liguori wrote:
>   
>> diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
>> index 413c569..49ae69b 100644
>> --- a/hw/mcf_fec.c
>> +++ b/hw/mcf_fec.c
>> @@ -446,8 +446,6 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t base, qemu_irq *irq)
>>      mcf_fec_state *s;
>>      int iomemtype;
>>  
>> -    qemu_check_nic_model(nd, "mcf_fec");
>>     
>
> It's obscure, but this line does three things:
>
>   1) Makes 'qemu-system-m68k -net nic,model=?' list the available model
>
>   2) Makes 'qemu-system-m68k -net nic,model=e1000' fail
>
>   3) Makes 'qemu-system-m68k -net nic' have sane 'info network' output 
>      - i.e. the model is listed as mcf_fec
>   

After looking at it, I'm inclined to just ignore these issues.  For the 
targets where this matters, you cannot specify anything other than the 
default nic models.  They all hard code what nics are available and just 
use the number of nics to determine whether to support multiple of those 
nics.

Regards,

Anthony Liguori

> That goes for the other non-PCI NICs too.
>
> Cheers,
> Mark.
>
>
>
>