From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqWLb-0002yn-Rk for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:41:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqWLX-0002w0-5k for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:41:31 -0400 Received: from [199.232.76.173] (port=34535 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqWLW-0002vs-Sn for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:41:26 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:38237) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LqWLW-0004CF-GB for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:41:26 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e39.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n35HcJ8P003794 for ; Sun, 5 Apr 2009 11:38:19 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n35HfPTw178602 for ; Sun, 5 Apr 2009 11:41:25 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n35HfOvI020569 for ; Sun, 5 Apr 2009 11:41:24 -0600 Message-ID: <49D8ED43.4030808@us.ibm.com> Date: Sun, 05 Apr 2009 12:41:23 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1238780602-7087-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1238780602-7087-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] pci_add storage: fix error handling for 'if' parameter Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org Eduardo Habkost wrote: > This fixes: > > - The error message to show the actual if= argument value. It was showing > the filename instead, because 'buf' is reaused on the filename parsing. > - A bug that makes a block device to be created even when an unsupported if= arg > is passed to pci_add. > > Signed-off-by: Eduardo Habkost > Applied. Thanks. Regards, Anthony Liguori