From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LqWN2-0003QG-K3
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:43:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LqWMx-0003Nx-Fo
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:43:00 -0400
Received: from [199.232.76.173] (port=34561 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LqWMx-0003Nj-3e
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:42:55 -0400
Received: from e39.co.us.ibm.com ([32.97.110.160]:38389)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LqWMw-0004O9-MR
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 13:42:54 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e39.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n35Hdm6N005175
	for <qemu-devel@nongnu.org>; Sun, 5 Apr 2009 11:39:48 -0600
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n35HgrFW178248
	for <qemu-devel@nongnu.org>; Sun, 5 Apr 2009 11:42:53 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n35HgrwT015976
	for <qemu-devel@nongnu.org>; Sun, 5 Apr 2009 11:42:53 -0600
Message-ID: <49D8ED9C.20304@us.ibm.com>
Date: Sun, 05 Apr 2009 12:42:52 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qcow2: fix image creation for large, > ~2TB,
	images
References: <20090403212849.GC27148@sequoia.sous-sol.org>
In-Reply-To: <20090403212849.GC27148@sequoia.sous-sol.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>

Chris Wright wrote:
> When creating large disk images w/ qcow2 format, qcow2_create is hard
> coded to creating a single refcount block.  This is insufficient for
> large images, and will cause qemu-img to segfault as it walks off the
> end of the refcount block.  Keep track of the space needed during image
> create and create proper number of refcount blocks accordingly.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=491943
>
> Signed-off-by: Chris Wright <chrisw@redhat.com>
>   

Applied.  Thanks.

Regards,

Anthony Liguori