From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqWvK-00051I-G5 for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:18:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqWvF-0004wC-I4 for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:18:25 -0400 Received: from [199.232.76.173] (port=37710 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqWvF-0004w1-Af for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:18:21 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:35351) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LqWvF-00081h-0q for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:18:21 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e8.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n35I9jBj013969 for ; Sun, 5 Apr 2009 14:09:45 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n35IIKbU198686 for ; Sun, 5 Apr 2009 14:18:20 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n35IIJP6022136 for ; Sun, 5 Apr 2009 14:18:19 -0400 Message-ID: <49D8F5EA.7080506@us.ibm.com> Date: Sun, 05 Apr 2009 13:18:18 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow2: fix image creation for large, > ~2TB, images References: <20090403212849.GC27148@sequoia.sous-sol.org> In-Reply-To: <20090403212849.GC27148@sequoia.sous-sol.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Glauber Costa Chris Wright wrote: > When creating large disk images w/ qcow2 format, qcow2_create is hard > coded to creating a single refcount block. This is insufficient for > large images, and will cause qemu-img to segfault as it walks off the > end of the refcount block. Keep track of the space needed during image > create and create proper number of refcount blocks accordingly. > > https://bugzilla.redhat.com/show_bug.cgi?id=491943 > > Signed-off-by: Chris Wright > Applied to stable. Thanks. -- Regards, Anthony Liguori