Re: [Qemu-devel] SH: support 7785 serial

[Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>]

Hi, Vladimir.
Thank you for your work.

Vladimir Prus wrote:
> These 3 patches make sh_serial.c support 7785 serial. The primary
> difference is that on 7785, instead of single fifo count register
> there are two separate ones -- for rx and tx. Patch 3 adds necessary
> conditional logic. Patches 1 and 2 are cleanups that I've done alone
> the way:
> 
> - Patch 1 makes it possible to change the size of RX fifo. It's 16
> on 7751 and 64 on 7785. While I do not know of any breakage if we
> use wrong size, it's still best to be correct.
> - Patch 2 replaces a pile of hardcoded constants with macroses.
> Also, the FSR register was handled strangely -- when written, we'd
> look at the written value and set bits in the 'flags' field, and on
> read, we'd reconstruct the value from the 'flags' field. There does
> not seem to be any reason for such roundabout, so I've made the code
> work with 'sr' directly.
> 
> This patch was tested both with r2d, using kernel and userland found
> at:
> 
> 	thttp://www.assembla.com/wiki/show/qemu-sh4/BuildingEnvironment
> 
> and with 7785, using a hand-made kernel.

Patch 2 produces a trouble in my environment.
For r2d, the output to SCIF from kernel is OK, but output from
shell is broken by inserted white space, like follows.

(before applying patch 2)
 # ls

(after applying patch2)
 #    l  s  

Do you have time to investigate it?


Regards,
Shin-ichiro KAWASAKI