From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LqppI-0008WV-1Q
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:29:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LqppC-0008VC-8N
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:29:26 -0400
Received: from [199.232.76.173] (port=43936 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LqppA-0008Us-98
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:29:21 -0400
Received: from rv-out-0708.google.com ([209.85.198.247]:33299)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Lqpp9-0007w7-UR
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:29:20 -0400
Received: by rv-out-0708.google.com with SMTP id l33so1771103rvb.22
	for <qemu-devel@nongnu.org>; Mon, 06 Apr 2009 07:29:17 -0700 (PDT)
Message-ID: <49DA11B7.2060705@codemonkey.ws>
Date: Mon, 06 Apr 2009 09:29:11 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen
	(v2) (Avi Kivity)
References: <E1LqXHT-0003bW-Bp@cvs.savannah.gnu.org>
	<49DA0FFD.1060600@eu.citrix.com>
In-Reply-To: <49DA0FFD.1060600@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Avi Kivity <avi@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Stefano Stabellini wrote:
> Anthony Liguori wrote:
>
> While I understand the problem this patch tries to fix I think the way
> it fixes it is wrong.
>
> First of all this patch breaks the VC switching mechanism in qemu: just
> execute sleep 2; startx; in the first VC, then switch to the monitor and
> wait.
> Secondly it doesn't follow the basic idea behind the DisplayState
> surface: it is supposed to be a pixel surface provided by the vga
> emulator to the frontends, cirrus shouldn't have to care what size it is.
> In fact cirrus emulates bitblit operations on the emulated framebuffer,
> not on the DisplayState surface; if it does so is a bug and should be fixed.
>
> For these reasons I think this patch should be reverted.
>   

Avi/Stefano, can one of you guys put together a proper patch?

Right now, it's better not to revert this patch because without it, our 
test suite cannot run.  However, I agree this is the wrong fix so we 
need to get a proper fix as soon as we can.

Regards,

Anthony Liguori

>
>