From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LqptB-0000vn-5s
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:33:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lqpt5-0000u8-Lw
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:33:28 -0400
Received: from [199.232.76.173] (port=58441 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lqpt2-0000tn-LR
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:33:21 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:57122)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1Lqpt2-0000AK-Ai
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:33:20 -0400
Message-ID: <49DA12AD.2030705@eu.citrix.com>
Date: Mon, 06 Apr 2009 15:33:17 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen
	(v2) (Avi Kivity)
References: <E1LqXHT-0003bW-Bp@cvs.savannah.gnu.org>
	<49DA0FFD.1060600@eu.citrix.com> <49DA11B7.2060705@codemonkey.ws>
In-Reply-To: <49DA11B7.2060705@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

Anthony Liguori wrote:

> Stefano Stabellini wrote:
>> Anthony Liguori wrote:
>>
>> While I understand the problem this patch tries to fix I think the way
>> it fixes it is wrong.
>>
>> First of all this patch breaks the VC switching mechanism in qemu: just
>> execute sleep 2; startx; in the first VC, then switch to the monitor and
>> wait.
>> Secondly it doesn't follow the basic idea behind the DisplayState
>> surface: it is supposed to be a pixel surface provided by the vga
>> emulator to the frontends, cirrus shouldn't have to care what size it is.
>> In fact cirrus emulates bitblit operations on the emulated framebuffer,
>> not on the DisplayState surface; if it does so is a bug and should be fixed.
>>
>> For these reasons I think this patch should be reverted.
>>   
> 
> Avi/Stefano, can one of you guys put together a proper patch?
> 
> Right now, it's better not to revert this patch because without it, our 
> test suite cannot run.  However, I agree this is the wrong fix so we 
> need to get a proper fix as soon as we can.
> 

Can you please let me know a simple way to reproduce the breakage Avi
was trying to fix?