From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LqqCi-0002im-Jz
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:53:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LqqCc-0002c0-Ha
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:53:39 -0400
Received: from [199.232.76.173] (port=34630 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LqqCc-0002bp-Bn
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:53:34 -0400
Received: from mx2.redhat.com ([66.187.237.31]:35282)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LqqCb-0003ri-SU
	for qemu-devel@nongnu.org; Mon, 06 Apr 2009 10:53:34 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n36ErWrh019536
	for <qemu-devel@nongnu.org>; Mon, 6 Apr 2009 10:53:32 -0400
Message-ID: <49DA176B.4090102@redhat.com>
Date: Mon, 06 Apr 2009 17:53:31 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen
	(v2) (Avi Kivity)
References: <E1LqXHT-0003bW-Bp@cvs.savannah.gnu.org>
	<49DA0FFD.1060600@eu.citrix.com> <49DA14A5.4060301@redhat.com>
In-Reply-To: <49DA14A5.4060301@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Avi Kivity wrote:
>> Secondly it doesn't follow the basic idea behind the DisplayState
>> surface: it is supposed to be a pixel surface provided by the vga
>> emulator to the frontends, cirrus shouldn't have to care what size it 
>> is.
>> In fact cirrus emulates bitblit operations on the emulated framebuffer,
>> not on the DisplayState surface; if it does so is a bug and should be 
>> fixed.
>>   
>
> This happens through cirrus_do_copy(), which implies that the display 
> surface is involved.  Is that wrong?

I think what you're saying is, we shouldn't call qemu_console_copy() in 
cirrus_do_copy() if vga is not displayed on the console?

(and conversely, if it is displayed, we shouldn't call 
cirrus_invalidate_region).

-- 
error compiling committee.c: too many arguments to function