From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lqtbk-0008ND-Cu for qemu-devel@nongnu.org; Mon, 06 Apr 2009 14:31:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lqtbf-0008LK-Mh for qemu-devel@nongnu.org; Mon, 06 Apr 2009 14:31:43 -0400 Received: from [199.232.76.173] (port=33921 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lqtbf-0008LF-F5 for qemu-devel@nongnu.org; Mon, 06 Apr 2009 14:31:39 -0400 Received: from mx2.redhat.com ([66.187.237.31]:57779) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lqtbe-00044w-VF for qemu-devel@nongnu.org; Mon, 06 Apr 2009 14:31:39 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n36IVcvi014997 for ; Mon, 6 Apr 2009 14:31:38 -0400 Message-ID: <49DA4AAF.10508@redhat.com> Date: Mon, 06 Apr 2009 21:32:15 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen (v2) (Avi Kivity) References: <49DA0FFD.1060600@eu.citrix.com> <49DA14A5.4060301@redhat.com> <49DA176B.4090102@redhat.com> <49DA3D7E.5050506@eu.citrix.com> <49DA400B.4060104@redhat.com> <49DA436F.5050801@eu.citrix.com> In-Reply-To: <49DA436F.5050801@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Avi Kivity wrote: > > >> Stefano Stabellini wrote: >> >>> I tried several times to manually reproduce the issue with no luck: if >>> no vnc clients are supposed to be connected, how do you make the cirrus >>> emulated hw do a bitblit? >>> >>> >> The guest will boot and do it by itself. >> > > > what is the OS? > In the cases I saw, I think it was Windows. Sorry, I can't be sure and I didn't keep any records. >>> In any case it makes sense that the problem is in qemu_console_copy() >>> rather than in the rop function itself that only operates on the >>> emulated framebuffer. >>> But calling qemu_console_copy() in cirrus_do_copy() shouldn't be risky >>> because before that, we call vga_hw_update() that should do the resize. >>> >>> >> vga_hw_update() may not actually do anything if the conditions are >> right, and maybe that's the case here. >> > > I thought about it, but if vga_hw_update does nothing, then > qemu_console_copy does nothing too. > True. >>> Without a better understanding of the bug I will refrain from making any >>> suggestion. >>> >>> >>> >> There's a backtrace in >> https://bugzilla.redhat.com/show_bug.cgi?id=494002. I'll also try to >> generate a good scenario for reproducing this. >> >> > > > thanks, that would be very useful (if it doesn't require me to compile > kvm it would be even better :)). > If you're running a recent distro it's already built in :) -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.