From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lr7fD-0001e5-F5
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 05:32:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lr7f8-0001cD-Qm
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 05:32:14 -0400
Received: from [199.232.76.173] (port=35881 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lr7f8-0001c1-FT
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 05:32:10 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:7041)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1Lr7f8-00039Y-6j
	for qemu-devel@nongnu.org; Tue, 07 Apr 2009 05:32:10 -0400
Message-ID: <49DB1D93.40908@eu.citrix.com>
Date: Tue, 07 Apr 2009 10:32:03 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen
	(v2) (Avi Kivity)
References: <E1LqXHT-0003bW-Bp@cvs.savannah.gnu.org>	<49DA0FFD.1060600@eu.citrix.com>
	<49DA11B7.2060705@codemonkey.ws>	<49DA12AD.2030705@eu.citrix.com>
	<49DA153A.40804@redhat.com> <20090407014407.GG11614@us.ibm.com>
	<49DB1CA6.4000307@redhat.com>
In-Reply-To: <49DB1CA6.4000307@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Avi Kivity wrote:

> I found the real cause - vga_screen_dump() left values for the current 
> display resolution in s->last_width and s->last_height.  This caused the 
> next vga_draw_graphic() to render to the 640x400 display surface it had 
> without resizing it.
> 
> The bug is triggered if you manage to screendump after a screen 
> resolution change, but before the next bitblit or console refresh.  If 
> no vnc or sdl client is connected, that's just the next bitblt so the 
> window is considerably longer.


This explains why it is so hard to reproduce.

 
> I'll follow up with a patch.  Anthony, please revert 6989 before 
> applying it.  Thanks to Stefano for pointing out the problems with the 
> patch.
> 


No problem :)