From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lr8RY-0007D7-DO for qemu-devel@nongnu.org; Tue, 07 Apr 2009 06:22:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lr8RT-0007AW-JT for qemu-devel@nongnu.org; Tue, 07 Apr 2009 06:22:11 -0400 Received: from [199.232.76.173] (port=41065 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lr8RT-0007AT-DJ for qemu-devel@nongnu.org; Tue, 07 Apr 2009 06:22:07 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54489) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lr8RS-0001Kp-VA for qemu-devel@nongnu.org; Tue, 07 Apr 2009 06:22:07 -0400 Message-ID: <49DB2948.6050701@redhat.com> Date: Tue, 07 Apr 2009 12:22:00 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 05/10] xen: add block device backend driver. References: <1238621982-18333-1-git-send-email-kraxel@redhat.com> <1238621982-18333-6-git-send-email-kraxel@redhat.com> <20090402170209.GA10089@lst.de> In-Reply-To: <20090402170209.GA10089@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Hi, > We already have bdrv_aio_readv/writev which currently linearize the > buffer underneath. Hopefully Anthony will have commited the patch to > implement the real one while I'm writing this, too :) Is there any specific reason to keep the nb_sectors argument for bdrv_aio_readv, other than cut&paste from the non-vectored versions? I think it is superfluous now, it can be trivially calculated using iov->size. cheers, Gerd