qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] buffer alignment for block backends
Date: Wed, 08 Apr 2009 14:35:06 +0100	[thread overview]
Message-ID: <49DCA80A.1020808@eu.citrix.com> (raw)

Hi all,
I am having an issue with the alignment of the buffers given to the
block backends. In particular, at the moment we are allocating buffers
512 bytes aligned while the backend I am working on (block-vbd) needs
page alignment.
Given that the 512 bytes alignment comes already from the requirements
of a "special case" (linux O_DIRECT, I guess), would you be willing to
make another exception for another special case and page align the buffers?

If you do not want to do that, another possible solution is to create a
new function called "qemu_blockalign" that would be implemented as
qemu_memalign(512, size); so we don't have to write 512 bytes everywhere
but only in one place, thus making life easier to people like me that
have to change the value for a special case.

Thanks in advance for your sympathy :)

Stefano Stabellini

             reply	other threads:[~2009-04-08 13:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08 13:35 Stefano Stabellini [this message]
2009-04-08 18:53 ` [Qemu-devel] buffer alignment for block backends Anthony Liguori
2009-04-09  9:57   ` Stefano Stabellini
2009-04-09 13:11     ` Anthony Liguori
2009-04-09 13:30       ` Stefano Stabellini
2009-04-09 13:54         ` Gerd Hoffmann
2009-04-09 15:21           ` Samuel Thibault
2009-04-09 15:46             ` Stefano Stabellini
2009-04-09 15:50             ` Gerd Hoffmann
2009-04-09 16:11               ` Stefano Stabellini
2009-04-09 16:13               ` Samuel Thibault
2009-04-09 16:28               ` Anthony Liguori
2009-04-09 15:55             ` Jamie Lokier
2009-04-09 16:15               ` Samuel Thibault
2009-04-09 17:29               ` Lennart Sorensen
2009-04-09 13:33       ` Stefano Stabellini
2009-04-09 15:19       ` Samuel Thibault
2009-04-09 15:38         ` Paul Brook
2009-04-09 15:40           ` Samuel Thibault
2009-04-09 15:56         ` Anthony Liguori
2009-04-09 16:19           ` Samuel Thibault
2009-04-09 10:07   ` Stefano Stabellini
2009-04-09 13:14     ` Anthony Liguori
2009-04-09 13:30       ` Stefano Stabellini
2009-04-09 13:19     ` Christoph Hellwig
2009-04-09 13:30       ` Stefano Stabellini
2009-04-09 15:31         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DCA80A.1020808@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).