From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrYSN-00052N-AA for qemu-devel@nongnu.org; Wed, 08 Apr 2009 10:08:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrYSI-00052B-N8 for qemu-devel@nongnu.org; Wed, 08 Apr 2009 10:08:47 -0400 Received: from [199.232.76.173] (port=40291 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrYSI-000528-KS for qemu-devel@nongnu.org; Wed, 08 Apr 2009 10:08:42 -0400 Received: from mx2.redhat.com ([66.187.237.31]:47751) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LrYSI-0003j1-3a for qemu-devel@nongnu.org; Wed, 08 Apr 2009 10:08:42 -0400 Message-ID: <49DCAFE4.40709@redhat.com> Date: Wed, 08 Apr 2009 16:08:36 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support. References: <1239115497-1884-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 04/07/09 19:30, Blue Swirl wrote: > On 4/7/09, Gerd Hoffmann wrote: >> Hi, >> >> Next round, addressing review comments. Bulk of the changes are just >> coding style, i.e. swap ordering of the funny "if (-1 == foo()) bar()" >> compare style. Also the FSF address is fixed everythere. And the > > There are still a lot of those funny comparisons. Oops. My grep missed the != comparisons. And a single one here and there. cheers, Gerd