From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core
Date: Wed, 08 Apr 2009 16:25:37 +0200 [thread overview]
Message-ID: <49DCB3E1.4030108@redhat.com> (raw)
In-Reply-To: <49DCA3CF.1080905@us.ibm.com>
On 04/08/09 15:17, Anthony Liguori wrote:
> I meant the public stuff too. I don't like having extern variables all
> over the place.
>
> It would be better to have this in a structure that was passed to all of
> the backend drivers that they then passed as a context. This will become
> more useful down the road too when we start introducing a common device
> model and finer grain locking.
The variables are more global xen state, not device / xenbus state. The
usage is not limited to the backend drivers, the domain builder code
will use them as well. There will never ever be more than one instance
of these. I don't see the point of placing them into a struct and
passing around a pointer.
cheers,
Gerd
next prev parent reply other threads:[~2009-04-08 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 14:44 [Qemu-devel] [PATCH 00/10] xen: pv domain support Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 01/10] xen: groundwork for xen support Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 02/10] xen: backend driver core Gerd Hoffmann
2009-04-07 19:41 ` Anthony Liguori
2009-04-08 9:21 ` Gerd Hoffmann
2009-04-08 9:52 ` Gerd Hoffmann
2009-04-08 13:17 ` Anthony Liguori
2009-04-08 14:25 ` Gerd Hoffmann [this message]
2009-04-07 14:44 ` [Qemu-devel] [PATCH 03/10] xen: add console backend driver Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 04/10] xen: add framebuffer " Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 05/10] xen: add block device " Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 06/10] xen: add net " Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 07/10] xen: blk & nic configuration via cmd line Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 08/10] xen: pv domain builder Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 09/10] simplify vga selection Gerd Hoffmann
2009-04-07 14:44 ` [Qemu-devel] [PATCH 10/10] xen: add -vga xenfb option, configure xenfb Gerd Hoffmann
2009-04-07 17:30 ` [Qemu-devel] [PATCH 00/10] xen: pv domain support Blue Swirl
2009-04-08 14:08 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2009-04-21 12:19 Gerd Hoffmann
2009-04-21 12:20 ` [Qemu-devel] [PATCH 02/10] xen: backend driver core Gerd Hoffmann
2009-04-01 21:39 [Qemu-devel] [PATCH 00/10] xen: pv domain support Gerd Hoffmann
2009-04-01 21:39 ` [Qemu-devel] [PATCH 02/10] xen: backend driver core Gerd Hoffmann
2009-04-02 16:49 ` Blue Swirl
2009-04-03 19:59 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DCB3E1.4030108@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).