From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] buffer alignment for block backends
Date: Thu, 09 Apr 2009 14:30:42 +0100 [thread overview]
Message-ID: <49DDF882.2050308@eu.citrix.com> (raw)
In-Reply-To: <20090409131951.GA17258@lst.de>
Christoph Hellwig wrote:
> On Thu, Apr 09, 2009 at 11:07:28AM +0100, Stefano Stabellini wrote:
>> + acb->bounce = qemu_blockalign(qiov->size);
>
> Why don't you pass a BlockDriverState to it so that it automatically
> does the best alignment for the underlying driver?
>
This is a good idea.
What if I add a new field to BlockDriverState called 'alignment'
defaulted to 512?
next prev parent reply other threads:[~2009-04-09 13:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 13:35 [Qemu-devel] buffer alignment for block backends Stefano Stabellini
2009-04-08 18:53 ` Anthony Liguori
2009-04-09 9:57 ` Stefano Stabellini
2009-04-09 13:11 ` Anthony Liguori
2009-04-09 13:30 ` Stefano Stabellini
2009-04-09 13:54 ` Gerd Hoffmann
2009-04-09 15:21 ` Samuel Thibault
2009-04-09 15:46 ` Stefano Stabellini
2009-04-09 15:50 ` Gerd Hoffmann
2009-04-09 16:11 ` Stefano Stabellini
2009-04-09 16:13 ` Samuel Thibault
2009-04-09 16:28 ` Anthony Liguori
2009-04-09 15:55 ` Jamie Lokier
2009-04-09 16:15 ` Samuel Thibault
2009-04-09 17:29 ` Lennart Sorensen
2009-04-09 13:33 ` Stefano Stabellini
2009-04-09 15:19 ` Samuel Thibault
2009-04-09 15:38 ` Paul Brook
2009-04-09 15:40 ` Samuel Thibault
2009-04-09 15:56 ` Anthony Liguori
2009-04-09 16:19 ` Samuel Thibault
2009-04-09 10:07 ` Stefano Stabellini
2009-04-09 13:14 ` Anthony Liguori
2009-04-09 13:30 ` Stefano Stabellini
2009-04-09 13:19 ` Christoph Hellwig
2009-04-09 13:30 ` Stefano Stabellini [this message]
2009-04-09 15:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DDF882.2050308@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).