From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrvE6-0000C4-89 for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:27:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrvE1-00009e-7I for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:27:33 -0400 Received: from [199.232.76.173] (port=52969 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrvE0-00009a-W2 for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:27:29 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44706) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LrvE0-0007J5-G2 for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:27:28 -0400 Message-ID: <49DE05F2.5060304@redhat.com> Date: Thu, 09 Apr 2009 17:28:02 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/6] Allow multiple monitor devices (v2) References: <1239215702-23818-1-git-send-email-aliguori@us.ibm.com> <49DDAF9F.7040400@redhat.com> <49DDF807.1050707@us.ibm.com> <49DDFAD5.7060808@redhat.com> <49DDFC5C.4080504@us.ibm.com> <49DE0042.9050103@redhat.com> <49DE0271.8090103@us.ibm.com> In-Reply-To: <49DE0271.8090103@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: libvir-list@redhat.com, Jan Kiszka , qemu-devel@nongnu.org, Hollis Blanchard Anthony Liguori wrote: >> >> Timestamping doesn't help since the command could have been delayed >> in the monitor socket. >> >> Further, we're now so deep down the complexity spiral that it has now >> become the most complicated piece of code in the entire system. > > You certainly cannot believe that, can you? It was one of my little exaggerations. But it does look disproportionatly complicated compared to the problem we're trying to solve. >> Surely the best way to synchronize events is to keep them on one >> timeline? > > Can you show exactly how you would expect things to work in the > monitor output? I'm having a hard time understanding what you're > suggesting. > (qemu) notify enospace on (qemu) notify vnc-connect on (qemu) notification: vnc connection ... (qemu) notify migration-completion on (qemu) migrate -d ... notification: enospc on ide0-0 (qemu) migrate_cancel notification: migration cancelled (qemu) migrate -d ... (qemu) notification: migration completed -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.