From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lrvhc-0001Fm-7U for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:58:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrvhX-0001Al-BJ for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:58:03 -0400 Received: from [199.232.76.173] (port=60002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrvhX-0001Af-6M for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:57:59 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:37257) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrvhW-0004At-O9 for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:57:58 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n39ExcbW027064 for ; Thu, 9 Apr 2009 10:59:38 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n39EvvD5148008 for ; Thu, 9 Apr 2009 10:57:57 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n39EuIJ8011146 for ; Thu, 9 Apr 2009 10:56:18 -0400 Message-ID: <49DE0CF2.3060307@us.ibm.com> Date: Thu, 09 Apr 2009 09:57:54 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/6] Allow multiple monitor devices (v2) References: <1239215702-23818-1-git-send-email-aliguori@us.ibm.com> <49DDAF9F.7040400@redhat.com> <49DDF807.1050707@us.ibm.com> <49DDFAD5.7060808@redhat.com> <49DDFC5C.4080504@us.ibm.com> <49DE0042.9050103@redhat.com> <49DE0271.8090103@us.ibm.com> <49DE05F2.5060304@redhat.com> <49DE0673.3070501@us.ibm.com> <49DE081D.1030702@redhat.com> In-Reply-To: <49DE081D.1030702@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: libvir-list@redhat.com, Jan Kiszka , qemu-devel@nongnu.org, Hollis Blanchard Avi Kivity wrote: > > I'd make everything line-oriented. Anything from the user up to \n is > buffered and ignored until the \n arrives. > > Once the \n arrives, the command is acted upon atomically, either > completing fully or launching an async notification. > > So the rules are: whenever the monitor is idle, a notification can be > printed out. So by idle, you mean, the end of the output buffer ends in either '\n' or '\n(qemu) '. The input buffer must also be empty. > (qemu) notify enospace on > (qemu) notify vnc-connect on > (qemu) > notification: vnc connection ... > (qemu) notify migration-completion on > (qemu) migrate -d ... > notification: enospc on ide0-0 > (qemu) migrate_cancel > notification: migration cancelled > (qemu) migrate -d ... > (qemu) > notification: migration completed This hurts my eyes. It's not human readable. If we're going to do this, we might as well have a non-human mode which would oddly enough be more human readable. If you do this, then your session looks an awful lot like my session from a previous note. I think the thing that is missing is that the 'wait' command does not have to be part of the non-human mode. In non-human mode, you are always doing an implicit wait. -- Regards, Anthony Liguori