Re: [libvirt] Re: [Qemu-devel] [PATCH 1/6] Allow multiple monitor devices (v2)

[Jan Kiszka <jan.kiszka@siemens.com>]

Avi Kivity wrote:
> Jan Kiszka wrote:
>> Avi Kivity wrote:
>>  
>>> Gerd Hoffmann wrote:
>>>    
>>>> On 04/09/09 16:03, Avi Kivity wrote:
>>>>      
>>>>> I don't want multiplexed monitor sessions, at all.
>>>>>         
>>>> I'm very happy to finally see them.  Finally one can run vms with
>>>> libvirt and *still* access the monitor for debugging and development
>>>> purposes.
>>>>
>>>>       
>>> Right, I like them for that purpose as well.  But not for ordinary
>>> control.
>>>     
>>
>> How do you want to differentiate? What further complications would this
>> bring us?
>>   
> 
> I'm not sure I understand your questions.  Multiple monitor sessions are
> like multiple shell sessions.  I don't think a control program should
> use more than one session, but it should allow a developer to connect to
> issue 'info registers' and 'x/20i' commands.  Of course if a developer
> issues 'quit' or a hotunplug command, things will break.

We agree if we want decoupled states of the monitor sessions (one
session should definitely not be used to configure the output of another
one). But I see no issues with collecting the events in one session that
happen to be caused by activity in some other session. But maybe I'm
missing your point.

>>
>> Please no more async notifications to the monitors. They are just ugly
>> to parse, at least for us humans. I don't want to see any notification
>> in the middle of my half-typed command e.g.
>>   
> 
> If we can identify an interactive session, we might redraw the partial
> command after the prompt.

Uhh, please not this kind of terminal reprinting. The terminal user keep
full control over when things can be printed.

> 
> btw, why would a human enable notifications?  Note notifications enabled
> on the management session will only be displayed there.

It's true that the common use case for events will be monitor
applications. Still, enabling them for testing or simple scripting
should not switch on ugly output mode or complicate the parsing.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux