qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Bruce Rogers <brogers@novell.com>
Subject: Re: [Qemu-devel] [PATCH] limit guest cpus for kvm enabled builds
Date: Thu, 09 Apr 2009 11:44:45 -0500	[thread overview]
Message-ID: <49DE25FD.3010503@codemonkey.ws> (raw)
In-Reply-To: <200904091705.20024.paul@codesourcery.com>

Paul Brook wrote:
> On Thursday 09 April 2009, Bruce Rogers wrote:
>   
>> The x86 kvm kernel module limits guest cpu count to 16, but the userspace
>> pc definition says 255 still.  When invoking qemu-kvm with -smp > 16, it
>> prints some error messages, then segfaults.   One of the mistakes is that
>> the error code from kvm_create_vcpu is ignored in ap_main_loop. 
>>     
>
> You should fix that bug then.
>   

I don't see the patch on the mailing list yet, but I'm pretty sure your 
patch is against kvm-userspace.git as ap_main_loop doesn't exist in 
upstream QEMU.

And FWIW, we do properly handle an unsupported -smp value in upstream 
QEMU when using KVM.

Regards,

Anthony Liguori

  reply	other threads:[~2009-04-09 16:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09 15:47 [Qemu-devel] [PATCH] limit guest cpus for kvm enabled builds Bruce Rogers
2009-04-09 16:05 ` Paul Brook
2009-04-09 16:44   ` Anthony Liguori [this message]
2009-04-09 17:27     ` Bruce Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DE25FD.3010503@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=brogers@novell.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).