From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LrxN4-00061c-6c
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 12:44:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LrxMz-0005z1-61
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 12:44:57 -0400
Received: from [199.232.76.173] (port=53019 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LrxMy-0005yS-5B
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 12:44:52 -0400
Received: from rv-out-0708.google.com ([209.85.198.250]:9905)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LrxMx-0005TP-DB
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 12:44:51 -0400
Received: by rv-out-0708.google.com with SMTP id l33so566704rvb.22
	for <qemu-devel@nongnu.org>; Thu, 09 Apr 2009 09:44:50 -0700 (PDT)
Message-ID: <49DE25FD.3010503@codemonkey.ws>
Date: Thu, 09 Apr 2009 11:44:45 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] limit guest cpus for kvm enabled builds
References: <49DDC4160200004800071C73@lucius.provo.novell.com>
	<200904091705.20024.paul@codesourcery.com>
In-Reply-To: <200904091705.20024.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Bruce Rogers <brogers@novell.com>

Paul Brook wrote:
> On Thursday 09 April 2009, Bruce Rogers wrote:
>   
>> The x86 kvm kernel module limits guest cpu count to 16, but the userspace
>> pc definition says 255 still.  When invoking qemu-kvm with -smp > 16, it
>> prints some error messages, then segfaults.   One of the mistakes is that
>> the error code from kvm_create_vcpu is ignored in ap_main_loop. 
>>     
>
> You should fix that bug then.
>   

I don't see the patch on the mailing list yet, but I'm pretty sure your 
patch is against kvm-userspace.git as ap_main_loop doesn't exist in 
upstream QEMU.

And FWIW, we do properly handle an unsupported -smp value in upstream 
QEMU when using KVM.

Regards,

Anthony Liguori