From: Anthony Liguori <aliguori@us.ibm.com>
To: Glauber Costa <glommer@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] register a single area for vga bios and option roms
Date: Thu, 09 Apr 2009 12:48:02 -0500 [thread overview]
Message-ID: <49DE34D2.3000803@us.ibm.com> (raw)
In-Reply-To: <1239292380-10032-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> Those guys are not different in nature. They're all roms,
> not blessed with the graces of being written to. So there's
> not need to issue multiple requests to memory registration areas:
> just treat them as brothers, and put them all in the same
> region.
>
> It also has the nice side effect of improving the loading code
> a little bit.
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
>
The vga bios is just an option rom, right? So why can't we treat the
vga bios as an option rom and eliminate the specific code for dealing
with VGA bios.
The real problem here is that we should be registering the option rom
space once and doing that in page boundaries.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-04-09 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 15:53 [Qemu-devel] [PATCH] register a single area for vga bios and option roms Glauber Costa
2009-04-09 17:48 ` Anthony Liguori [this message]
2009-04-09 20:49 ` [Qemu-devel] " Carl-Daniel Hailfinger
2009-04-09 22:15 ` Glauber Costa
2009-04-11 7:41 ` Zachary Amsden
2009-04-09 17:55 ` [Qemu-devel] " Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DE34D2.3000803@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).