From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LryMG-000143-GJ
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:48:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LryMB-00013k-3j
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:48:11 -0400
Received: from [199.232.76.173] (port=56056 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LryMA-00013h-Ut
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:48:06 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:50196)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LryMA-00069b-4Z
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:48:06 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n39HigBM003483
	for <qemu-devel@nongnu.org>; Thu, 9 Apr 2009 13:44:42 -0400
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n39Hm4b9093648
	for <qemu-devel@nongnu.org>; Thu, 9 Apr 2009 13:48:04 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n39Hm46F009381
	for <qemu-devel@nongnu.org>; Thu, 9 Apr 2009 13:48:04 -0400
Message-ID: <49DE34D2.3000803@us.ibm.com>
Date: Thu, 09 Apr 2009 12:48:02 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1239292380-10032-1-git-send-email-glommer@redhat.com>
In-Reply-To: <1239292380-10032-1-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] register a single area for vga bios and
	option roms
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org

Glauber Costa wrote:
> Those guys are not different in nature. They're all roms,
> not blessed with the graces of being written to. So there's
> not need to issue multiple requests to memory registration areas:
> just treat them as brothers, and put them all in the same
> region.
>
> It also has the nice side effect of improving the loading code
> a little bit.
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
>   

The vga bios is just an option rom, right?  So why can't we treat the 
vga bios as an option rom and eliminate the specific code for dealing 
with VGA bios.

The real problem here is that we should be registering the option rom 
space once and doing that in page boundaries.

Regards,

Anthony Liguori