From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LrySC-0002To-Q6
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:54:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LryS7-0002Sc-Jp
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:54:19 -0400
Received: from [199.232.76.173] (port=38418 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LryS7-0002ST-AS
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:54:15 -0400
Received: from yx-out-1718.google.com ([74.125.44.157]:13104)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LryS6-0006qB-VY
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 13:54:15 -0400
Received: by yx-out-1718.google.com with SMTP id 34so451362yxf.82
	for <qemu-devel@nongnu.org>; Thu, 09 Apr 2009 10:54:14 -0700 (PDT)
Message-ID: <49DE3641.9090900@codemonkey.ws>
Date: Thu, 09 Apr 2009 12:54:09 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns
References: <1239284776-2115-1-git-send-email-kwolf@redhat.com>	<20090409153314.GB22492@lst.de>
	<200904091907.45921@kevin-wolf.de>
In-Reply-To: <200904091907.45921@kevin-wolf.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>

Kevin Wolf wrote:
>
> This is what you get for using tabs. You deserve it. ;-)
>
> Seriously, I found this really annoying when I did the patch because almost 
> everything else in qemu has four spaces and I needed to change my editor 
> settings for just this file. But I still left indentation on four characters, 
> so this line did fit for me.
>
> I can either send a second version of the patch which fixes this line, or we 
> could have a patch which changes the indentation of the whole file to four 
> spaces (as specified in the coding style document). qemu-io might be new 
> enough to not destroy valuable svn blame information with such a patch.
>   

The only reason I merged it as-is is because the code was derived from 
something else.  I didn't want to force a reindentation that would make 
it harder to keep the code synced against the upstream project.

Regards,

Anthony Liguori