From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls1C6-0002eo-Ch for qemu-devel@nongnu.org; Thu, 09 Apr 2009 16:49:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls1C1-0002eW-7Y for qemu-devel@nongnu.org; Thu, 09 Apr 2009 16:49:53 -0400 Received: from [199.232.76.173] (port=58875 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls1C1-0002eT-1y for qemu-devel@nongnu.org; Thu, 09 Apr 2009 16:49:49 -0400 Received: from mail.gmx.net ([213.165.64.20]:44498) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Ls1C0-0003yQ-FE for qemu-devel@nongnu.org; Thu, 09 Apr 2009 16:49:48 -0400 Message-ID: <49DE5F68.2010108@gmx.net> Date: Thu, 09 Apr 2009 22:49:44 +0200 From: Carl-Daniel Hailfinger MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] register a single area for vga bios and option roms References: <1239292380-10032-1-git-send-email-glommer@redhat.com> <49DE34D2.3000803@us.ibm.com> In-Reply-To: <49DE34D2.3000803@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, Glauber Costa On 09.04.2009 19:48, Anthony Liguori wrote: > Glauber Costa wrote: >> Those guys are not different in nature. They're all roms, >> not blessed with the graces of being written to. So there's >> not need to issue multiple requests to memory registration areas: >> just treat them as brothers, and put them all in the same >> region. >> >> It also has the nice side effect of improving the loading code >> a little bit. >> >> Signed-off-by: Glauber Costa >> > > The vga bios is just an option rom, right? So why can't we treat the > vga bios as an option rom and eliminate the specific code for dealing > with VGA bios. > > The real problem here is that we should be registering the option rom > space once and doing that in page boundaries. AFAIK shadowed option ROMs can be aligned at 1 kB boundaries and may modify themselves. Quite a few VGA BIOSes do that to reduce their memory footprint after hardware initialization is complete. Regards, Carl-Daniel -- http://www.hailfinger.org/