From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtIXC-00055c-E6 for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:32:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtIX6-00054n-Sj for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:32:57 -0400 Received: from [199.232.76.173] (port=44319 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtIX6-00054k-MZ for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:32:52 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42002) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LtIX6-0002dd-64 for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:32:52 -0400 Message-ID: <49E306C0.1050505@redhat.com> Date: Mon, 13 Apr 2009 12:32:48 +0300 From: Avi Kivity MIME-Version: 1.0 References: <49E06754.8050906@web.de> In-Reply-To: <49E06754.8050906@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] kvm: Fix overlapping check for memory slots Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Glauber Costa , qemu-devel , kvm-devel Jan Kiszka wrote: > This nice little buglet complicates a smarter slot management in qemu > user space just "slightly". Sigh... > > --------> > > When checking for overlapping slots on registration of a new one, kvm > currently also considers zero-length (ie. deleted) slots and rejects > requests incorrectly. This finally denies user space from joining slots. > Fix the check by skipping deleted slots. > Can userspace fail gracefully when the bug is present? If not, the you should add a KVM_CAP_ to advertise the fix; without the capability don't attempt the smarter slot management. -- error compiling committee.c: too many arguments to function