From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LtIge-0008SJ-48
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:42:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LtIgZ-0008Oc-AP
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:42:43 -0400
Received: from [199.232.76.173] (port=34687 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LtIgY-0008OT-Oe
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:42:38 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:54388)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1LtIgY-0005Td-3o
	for qemu-devel@nongnu.org; Mon, 13 Apr 2009 05:42:38 -0400
Message-ID: <49E3090B.2090200@web.de>
Date: Mon, 13 Apr 2009 11:42:35 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <49E06754.8050906@web.de> <49E306C0.1050505@redhat.com>
In-Reply-To: <49E306C0.1050505@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigD19422348D456B296BA8C595"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix overlapping check for memory slots
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD19422348D456B296BA8C595
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Avi Kivity wrote:
> Jan Kiszka wrote:
>> This nice little buglet complicates a smarter slot management in qemu
>> user space just "slightly". Sigh...
>>
>> -------->
>>
>> When checking for overlapping slots on registration of a new one, kvm
>> currently also considers zero-length (ie. deleted) slots and rejects
>> requests incorrectly. This finally denies user space from joining slot=
s.
>> Fix the check by skipping deleted slots.
>>  =20
>=20
> Can userspace fail gracefully when the bug is present?  If not, the you=

> should add a KVM_CAP_ to advertise the fix; without the capability don'=
t
> attempt the smarter slot management.

I already thought about adding some
KVM_CAP_DESTROY_MEMORY_REGION_NOW_REALLY_WORKS and skip the workaround
in [1]. Maybe a good idea, comments welcome.

Jan

[1] http://permalink.gmane.org/gmane.comp.emulators.qemu/41326


--------------enigD19422348D456B296BA8C595
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAknjCQsACgkQniDOoMHTA+mKlACdHxuQ8tGw9RkK1AnLl1xwjwoL
opoAn3xZPznP2GkPuZDxtqHIRvkftMfv
=t6Gt
-----END PGP SIGNATURE-----

--------------enigD19422348D456B296BA8C595--