From: Zachary Amsden <zamsden@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Fix changing password using monitor over VNC.
Date: Thu, 16 Apr 2009 21:43:41 -1000 [thread overview]
Message-ID: <49E8332D.8090500@redhat.com> (raw)
In-Reply-To: <49E8292A.8080900@web.de>
Jan Kiszka wrote:
> Zachary Amsden wrote:
>> A simple segfault turned out to be a relatively complex fix.
>>
>> The monitor calls back to main_loop_wait() to wait for the completion
>> of the password change event; this results in a nested invocation of
>
> This is no longer true with trunk as this nasty blocking password
> reading has been converted into an async operation. Is your patch
> required nevertheless? Or is this band-aid for stable?
I confirmed the bug, verified the fix on a git tree sync'd today from
git://git.savannah.nongnu.org/qemu.git
let me know if this is not the trunk.
Sorry, as I am new to qemu development.
Cheers,
Zach
next prev parent reply other threads:[~2009-04-17 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 5:06 [Qemu-devel] [PATCH] Fix changing password using monitor over VNC Zachary Amsden
2009-04-17 7:00 ` [Qemu-devel] " Jan Kiszka
2009-04-17 7:43 ` Zachary Amsden [this message]
2009-04-17 8:31 ` Jan Kiszka
2009-04-18 3:31 ` Zachary Amsden
2009-04-18 8:41 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E8332D.8090500@redhat.com \
--to=zamsden@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).