From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LuikJ-0004PG-T5 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 03:44:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LuikF-0004P4-Dy for qemu-devel@nongnu.org; Fri, 17 Apr 2009 03:44:23 -0400 Received: from [199.232.76.173] (port=41570 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LuikF-0004P1-B2 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 03:44:19 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51440) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LuikE-0004gc-RK for qemu-devel@nongnu.org; Fri, 17 Apr 2009 03:44:19 -0400 Message-ID: <49E8332D.8090500@redhat.com> Date: Thu, 16 Apr 2009 21:43:41 -1000 From: Zachary Amsden MIME-Version: 1.0 References: <1239944809-14327-1-git-send-email-zamsden@redhat.com> <49E8292A.8080900@web.de> In-Reply-To: <49E8292A.8080900@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Fix changing password using monitor over VNC. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Jan Kiszka wrote: > Zachary Amsden wrote: >> A simple segfault turned out to be a relatively complex fix. >> >> The monitor calls back to main_loop_wait() to wait for the completion >> of the password change event; this results in a nested invocation of > > This is no longer true with trunk as this nasty blocking password > reading has been converted into an async operation. Is your patch > required nevertheless? Or is this band-aid for stable? I confirmed the bug, verified the fix on a git tree sync'd today from git://git.savannah.nongnu.org/qemu.git let me know if this is not the trunk. Sorry, as I am new to qemu development. Cheers, Zach