[Qemu-devel] Re: [patch 02/11] qemu: mutex/thread/cond wrappers

[Anthony Liguori <aliguori@us.ibm.com>]

mtosatti@redhat.com wrote:
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
>
> Index: trunk/configure
> ===================================================================
> --- trunk.orig/configure
> +++ trunk/configure
> @@ -180,6 +180,7 @@ build_docs="no"
>  uname_release=""
>  curses="yes"
>  aio="yes"
> +io_thread="no"
>  nptl="yes"
>  mixemu="no"
>  bluez="yes"
> @@ -463,6 +464,8 @@ for opt do
>    ;;
>    --disable-aio) aio="no"
>    ;;
> +  --enable-io-thread) io_thread="yes"
> +  ;;
>    --disable-blobs) blobs="no"
>    ;;
>    --kerneldir=*) kerneldir="$optarg"
> @@ -577,6 +580,7 @@ echo "  --enable-uname-release=R Return 
>  echo "  --sparc_cpu=V            Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
>  echo "  --disable-vde            disable support for vde network"
>  echo "  --disable-aio            disable AIO support"
> +echo "  --enable-io-thread       enable IO thread"
>  echo "  --disable-blobs          disable installing provided firmware blobs"
>  echo "  --kerneldir=PATH         look for kernel includes in PATH"
>  echo ""
> @@ -1204,6 +1208,7 @@ echo "uname -r          $uname_release"
>  echo "NPTL support      $nptl"
>  echo "vde support       $vde"
>  echo "AIO support       $aio"
> +echo "IO thread         $io_thread"
>  echo "Install blobs     $blobs"
>  echo "KVM support       $kvm"
>  echo "fdt support       $fdt"
> @@ -1500,6 +1505,10 @@ if test "$aio" = "yes" ; then
>    echo "#define CONFIG_AIO 1" >> $config_h
>    echo "CONFIG_AIO=yes" >> $config_mak
>  fi
> +if test "$io_thread" = "yes" ; then
> +  echo "CONFIG_IOTHREAD=yes" >> $config_mak
> +  echo "#define CONFIG_IOTHREAD 1" >> $config_h
> +fi
>  if test "$blobs" = "yes" ; then
>    echo "INSTALL_BLOBS=yes" >> $config_mak
>  fi
>   

You'll need to probe pthread.  For instance, 'configure --disable-aio 
--enable-io-thread' would succeed but result in a broken build.  You 
should probably break out the pthread probing from CONFIG_AIO, then make 
CONFIG_AIO and CONFIG_IO_THREAD depend on CONFIG_PTHREAD.

Also, we should convert posix-aio-compat.c to qemu_thread but that can 
wait...

Regards,

Anthony Liguori