From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LuoW9-000672-7Y for qemu-devel@nongnu.org; Fri, 17 Apr 2009 09:54:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LuoW4-00064l-5i for qemu-devel@nongnu.org; Fri, 17 Apr 2009 09:54:08 -0400 Received: from [199.232.76.173] (port=43687 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LuoW4-00064f-0n for qemu-devel@nongnu.org; Fri, 17 Apr 2009 09:54:04 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:45069) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LuoW3-0003aT-Gr for qemu-devel@nongnu.org; Fri, 17 Apr 2009 09:54:03 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3HDoPiI000397 for ; Fri, 17 Apr 2009 09:50:25 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3HDrxNN176988 for ; Fri, 17 Apr 2009 09:53:59 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3HDrxeP018721 for ; Fri, 17 Apr 2009 09:53:59 -0400 Message-ID: <49E889F5.4000507@us.ibm.com> Date: Fri, 17 Apr 2009 08:53:57 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20090407195126.467365249@localhost.localdomain> <20090407195442.764405844@localhost.localdomain> In-Reply-To: <20090407195442.764405844@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch 02/11] qemu: mutex/thread/cond wrappers Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mtosatti@redhat.com, "qemu-devel@nongnu.org" mtosatti@redhat.com wrote: > Signed-off-by: Marcelo Tosatti > > > Index: trunk/configure > =================================================================== > --- trunk.orig/configure > +++ trunk/configure > @@ -180,6 +180,7 @@ build_docs="no" > uname_release="" > curses="yes" > aio="yes" > +io_thread="no" > nptl="yes" > mixemu="no" > bluez="yes" > @@ -463,6 +464,8 @@ for opt do > ;; > --disable-aio) aio="no" > ;; > + --enable-io-thread) io_thread="yes" > + ;; > --disable-blobs) blobs="no" > ;; > --kerneldir=*) kerneldir="$optarg" > @@ -577,6 +580,7 @@ echo " --enable-uname-release=R Return > echo " --sparc_cpu=V Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9" > echo " --disable-vde disable support for vde network" > echo " --disable-aio disable AIO support" > +echo " --enable-io-thread enable IO thread" > echo " --disable-blobs disable installing provided firmware blobs" > echo " --kerneldir=PATH look for kernel includes in PATH" > echo "" > @@ -1204,6 +1208,7 @@ echo "uname -r $uname_release" > echo "NPTL support $nptl" > echo "vde support $vde" > echo "AIO support $aio" > +echo "IO thread $io_thread" > echo "Install blobs $blobs" > echo "KVM support $kvm" > echo "fdt support $fdt" > @@ -1500,6 +1505,10 @@ if test "$aio" = "yes" ; then > echo "#define CONFIG_AIO 1" >> $config_h > echo "CONFIG_AIO=yes" >> $config_mak > fi > +if test "$io_thread" = "yes" ; then > + echo "CONFIG_IOTHREAD=yes" >> $config_mak > + echo "#define CONFIG_IOTHREAD 1" >> $config_h > +fi > if test "$blobs" = "yes" ; then > echo "INSTALL_BLOBS=yes" >> $config_mak > fi > You'll need to probe pthread. For instance, 'configure --disable-aio --enable-io-thread' would succeed but result in a broken build. You should probably break out the pthread probing from CONFIG_AIO, then make CONFIG_AIO and CONFIG_IO_THREAD depend on CONFIG_PTHREAD. Also, we should convert posix-aio-compat.c to qemu_thread but that can wait... Regards, Anthony Liguori